{"componentChunkName":"component---node-modules-rocketseat-gatsby-theme-docs-core-src-templates-docs-query-js","path":"/code-style/PluginV1-PV1","result":{"data":{"mdx":{"id":"4cc0f70e-128a-5448-84eb-e87ec2b4ebfa","excerpt":"PV1-01C: Duplicate Validation of Initialization Type Severity Location Gas Optimization PluginV1.sol:L380 , L381 Description: The PluginV1::initialize…","fields":{"slug":"/code-style/PluginV1-PV1/"},"frontmatter":{"title":"PluginV1 Code Style Findings","description":"Contains all the findings that relate to code style on the contract codebase","image":null,"disableTableOfContents":null},"body":"var _excluded = [\"components\"];\n\nfunction _extends() { _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; }; return _extends.apply(this, arguments); }\n\nfunction _objectWithoutProperties(source, excluded) { if (source == null) return {}; var target = _objectWithoutPropertiesLoose(source, excluded); var key, i; if (Object.getOwnPropertySymbols) { var sourceSymbolKeys = Object.getOwnPropertySymbols(source); for (i = 0; i < sourceSymbolKeys.length; i++) { key = sourceSymbolKeys[i]; if (excluded.indexOf(key) >= 0) continue; if (!Object.prototype.propertyIsEnumerable.call(source, key)) continue; target[key] = source[key]; } } return target; }\n\nfunction _objectWithoutPropertiesLoose(source, excluded) { if (source == null) return {}; var target = {}; var sourceKeys = Object.keys(source); var key, i; for (i = 0; i < sourceKeys.length; i++) { key = sourceKeys[i]; if (excluded.indexOf(key) >= 0) continue; target[key] = source[key]; } return target; }\n\n/* @jsxRuntime classic */\n\n/* @jsx mdx */\nvar _frontmatter = {\n \"title\": \"PluginV1 Code Style Findings\",\n \"description\": \"Contains all the findings that relate to code style on the contract codebase\"\n};\nvar layoutProps = {\n _frontmatter: _frontmatter\n};\nvar MDXLayout = \"wrapper\";\nreturn function MDXContent(_ref) {\n var components = _ref.components,\n props = _objectWithoutProperties(_ref, _excluded);\n\n return mdx(MDXLayout, _extends({}, layoutProps, props, {\n components: components,\n mdxType: \"MDXLayout\"\n }), mdx(\"h2\", {\n \"id\": \"span-idpv1-01cpv1-01c-duplicate-validation-of-initializationspan\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h2\",\n \"href\": \"#span-idpv1-01cpv1-01c-duplicate-validation-of-initializationspan\",\n \"aria-label\": \"span idpv1 01cpv1 01c duplicate validation of initializationspan permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), mdx(\"span\", {\n id: \"PV1-01C\"\n }, \"PV1-01C: Duplicate Validation of Initialization\")), mdx(\"table\", null, mdx(\"thead\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"thead\"\n }, mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Type\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Severity\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Location\"))), mdx(\"tbody\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"tbody\"\n }, mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"/reports/steer-protocol-algebra-v4-hook-integration-688c6d5b07dd3b0018c7b26d/appendix/finding-types#gas-optimization\"\n }, \"Gas Optimization\")), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"img\", {\n parentName: \"td\",\n \"className\": \"o-severity o-informational\",\n \"src\": \"https://omniscia.io/report-assets/informational.png\"\n })), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L380\"\n }, \"PluginV1.sol:L380\"), \", \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L381\"\n }, \"L381\"))))), mdx(\"h3\", {\n \"id\": \"description\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#description\",\n \"aria-label\": \"description permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Description:\"), mdx(\"p\", null, \"The \", mdx(\"a\", {\n parentName: \"p\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L375-L445\"\n }, mdx(\"inlineCode\", {\n parentName: \"a\"\n }, \"PluginV1::initialize\")), \" function will prevent initialization via two distinct conditionals; one imposed in the \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"Initializable::initializer\"), \" implementation and one via a direct \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"require\"), \" check in the \", mdx(\"a\", {\n parentName: \"p\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L375-L445\"\n }, mdx(\"inlineCode\", {\n parentName: \"a\"\n }, \"PluginV1::initialize\")), \" function.\"), mdx(\"h3\", {\n \"id\": \"example\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#example\",\n \"aria-label\": \"example permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n parentName: \"pre\",\n \"className\": \"language-sol\",\n \"metastring\": \"title=src/Adapters/Algebra/PluginV1.sol highlight={6,7} lineNumbers=true lineOffset=374\",\n \"title\": \"src/Adapters/Algebra/PluginV1.sol\",\n \"highlight\": \"{6,7}\",\n \"lineNumbers\": \"true\",\n \"lineOffset\": \"374\"\n }, \"function initialize(\\n address,\\n address _orchestrator,\\n address _steer,\\n bytes memory _params\\n) external initializer {\\n require(!isInitialized, \\\"AI\\\");\\n\")), mdx(\"h3\", {\n \"id\": \"recommendation\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#recommendation\",\n \"aria-label\": \"recommendation permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise the latter to be omitted, optimizing the code's gas cost.\"), mdx(\"h3\", {\n \"id\": \"alleviation\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#alleviation\",\n \"aria-label\": \"alleviation permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Alleviation:\"), mdx(\"p\", null, \"The redundant \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"isInitialized\"), \" validation and concept has been omitted as advised.\"), mdx(ViewDiffButton, {\n repoUrl: \"https://github.com/SteerProtocol/core-v2\",\n mainHash: \"1eef5f69971e4d1ffa77012516646a38aa38517c\",\n fixHash: \"4f6535a8a25ddd41794119143a2d73d01f4c6d34\",\n gitHubIssue: \"0\",\n mdxType: \"ViewDiffButton\"\n }), mdx(\"h2\", {\n \"id\": \"span-idpv1-02cpv1-02c-generic-typographic-mistakespan\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h2\",\n \"href\": \"#span-idpv1-02cpv1-02c-generic-typographic-mistakespan\",\n \"aria-label\": \"span idpv1 02cpv1 02c generic typographic mistakespan permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), mdx(\"span\", {\n id: \"PV1-02C\"\n }, \"PV1-02C: Generic Typographic Mistake\")), mdx(\"table\", null, mdx(\"thead\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"thead\"\n }, mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Type\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Severity\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Location\"))), mdx(\"tbody\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"tbody\"\n }, mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"/reports/steer-protocol-algebra-v4-hook-integration-688c6d5b07dd3b0018c7b26d/appendix/finding-types#code-style\"\n }, \"Code Style\")), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"img\", {\n parentName: \"td\",\n \"className\": \"o-severity o-informational\",\n \"src\": \"https://omniscia.io/report-assets/informational.png\"\n })), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L423\"\n }, \"PluginV1.sol:L423\"))))), mdx(\"h3\", {\n \"id\": \"description-1\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#description-1\",\n \"aria-label\": \"description 1 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Description:\"), mdx(\"p\", null, \"The referenced line contains a typographical mistake (i.e. \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"private\"), \" variable without an underscore prefix, a non-\", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"snake_case\"), \" module) or generic documentational error (i.e. copy-paste) that should be corrected.\"), mdx(\"h3\", {\n \"id\": \"example-1\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#example-1\",\n \"aria-label\": \"example 1 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n parentName: \"pre\",\n \"className\": \"language-sol\",\n \"metastring\": \"title=src/Adapters/Algebra/PluginV1.sol highlight={1} lineNumbers=true lineOffset=422\",\n \"title\": \"src/Adapters/Algebra/PluginV1.sol\",\n \"highlight\": \"{1}\",\n \"lineNumbers\": \"true\",\n \"lineOffset\": \"422\"\n }, \"maximumUsedPercent = params.maximumUsedPercent;\\n\")), mdx(\"h3\", {\n \"id\": \"recommendation-1\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#recommendation-1\",\n \"aria-label\": \"recommendation 1 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise this to be done so to enhance the legibility of the codebase.\"), mdx(\"h3\", {\n \"id\": \"alleviation-1\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#alleviation-1\",\n \"aria-label\": \"alleviation 1 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Alleviation:\"), mdx(\"p\", null, \"The Steer Protocol team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.\"), mdx(\"h2\", {\n \"id\": \"span-idpv1-03cpv1-03c-inefficient-signature-encodingsspan\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h2\",\n \"href\": \"#span-idpv1-03cpv1-03c-inefficient-signature-encodingsspan\",\n \"aria-label\": \"span idpv1 03cpv1 03c inefficient signature encodingsspan permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), mdx(\"span\", {\n id: \"PV1-03C\"\n }, \"PV1-03C: Inefficient Signature Encodings\")), mdx(\"table\", null, mdx(\"thead\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"thead\"\n }, mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Type\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Severity\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Location\"))), mdx(\"tbody\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"tbody\"\n }, mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"/reports/steer-protocol-algebra-v4-hook-integration-688c6d5b07dd3b0018c7b26d/appendix/finding-types#gas-optimization\"\n }, \"Gas Optimization\")), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"img\", {\n parentName: \"td\",\n \"className\": \"o-severity o-informational\",\n \"src\": \"https://omniscia.io/report-assets/informational.png\"\n })), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"b\", null, \"PluginV1.sol\"), \":\", mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 1\"\n }, \"I-1:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L281\"\n }, \"L281\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 2\"\n }, \"I-2:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L541\"\n }, \"L541\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 3\"\n }, \"I-3:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L731-L743\"\n }, \"L731-L743\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 4\"\n }, \"I-4:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L793-L800\"\n }, \"L793-L800\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 5\"\n }, \"I-5:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L829-L831\"\n }, \"L829-L831\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 6\"\n }, \"I-6:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L841-L843\"\n }, \"L841-L843\"))))), mdx(\"h3\", {\n \"id\": \"description-2\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#description-2\",\n \"aria-label\": \"description 2 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Description:\"), mdx(\"p\", null, \"The referenced statements employ the \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"abi.encodeWithSignature\"), \" function even though the function names are known during compilation time.\"), mdx(\"h3\", {\n \"id\": \"example-2\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#example-2\",\n \"aria-label\": \"example 2 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n parentName: \"pre\",\n \"className\": \"language-sol\",\n \"metastring\": \"title=src/Adapters/Algebra/PluginV1.sol highlight={1} lineNumbers=true lineOffset=280\",\n \"title\": \"src/Adapters/Algebra/PluginV1.sol\",\n \"highlight\": \"{1}\",\n \"lineNumbers\": \"true\",\n \"lineOffset\": \"280\"\n }, \"(bool success,) = address(this).call(abi.encodeWithSignature(\\\"_handleSwapLogic()\\\"));\\n\")), mdx(\"h3\", {\n \"id\": \"recommendation-2\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#recommendation-2\",\n \"aria-label\": \"recommendation 2 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise all statements to be replaced with the \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"abi.encodeWithSelector\"), \" function instead, utilizing the properly computed \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"bytes4\"), \" selectors of each function by importing an \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"interface\"), \" and using the selector syntax (i.e. \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"IERC20.transferFrom.selector\"), \").\"), mdx(\"h3\", {\n \"id\": \"alleviation-2\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#alleviation-2\",\n \"aria-label\": \"alleviation 2 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Alleviation:\"), mdx(\"p\", null, \"The Steer Protocol team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.\"), mdx(\"h2\", {\n \"id\": \"span-idpv1-04cpv1-04c-inexistent-error-messagesspan\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h2\",\n \"href\": \"#span-idpv1-04cpv1-04c-inexistent-error-messagesspan\",\n \"aria-label\": \"span idpv1 04cpv1 04c inexistent error messagesspan permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), mdx(\"span\", {\n id: \"PV1-04C\"\n }, \"PV1-04C: Inexistent Error Messages\")), mdx(\"table\", null, mdx(\"thead\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"thead\"\n }, mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Type\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Severity\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Location\"))), mdx(\"tbody\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"tbody\"\n }, mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"/reports/steer-protocol-algebra-v4-hook-integration-688c6d5b07dd3b0018c7b26d/appendix/finding-types#code-style\"\n }, \"Code Style\")), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"img\", {\n parentName: \"td\",\n \"className\": \"o-severity o-informational\",\n \"src\": \"https://omniscia.io/report-assets/informational.png\"\n })), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"b\", null, \"PluginV1.sol\"), \":\", mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 1\"\n }, \"I-1:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L235\"\n }, \"L235\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 2\"\n }, \"I-2:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L236\"\n }, \"L236\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 3\"\n }, \"I-3:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L289\"\n }, \"L289\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 4\"\n }, \"I-4:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L420\"\n }, \"L420\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 5\"\n }, \"I-5:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L428\"\n }, \"L428\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 6\"\n }, \"I-6:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L466\"\n }, \"L466\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 7\"\n }, \"I-7:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L510\"\n }, \"L510\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 8\"\n }, \"I-8:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L512\"\n }, \"L512\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 9\"\n }, \"I-9:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L527\"\n }, \"L527\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 10\"\n }, \"I-10:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L528\"\n }, \"L528\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 11\"\n }, \"I-11:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L641\"\n }, \"L641\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 12\"\n }, \"I-12:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L659\"\n }, \"L659\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 13\"\n }, \"I-13:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L664\"\n }, \"L664\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 14\"\n }, \"I-14:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L789\"\n }, \"L789\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 15\"\n }, \"I-15:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L825\"\n }, \"L825\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 16\"\n }, \"I-16:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L863\"\n }, \"L863\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 17\"\n }, \"I-17:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L881\"\n }, \"L881\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 18\"\n }, \"I-18:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L882\"\n }, \"L882\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 19\"\n }, \"I-19:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L889\"\n }, \"L889\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 20\"\n }, \"I-20:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L890\"\n }, \"L890\"))))), mdx(\"h3\", {\n \"id\": \"description-3\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#description-3\",\n \"aria-label\": \"description 3 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Description:\"), mdx(\"p\", null, \"The linked \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"require\"), \" checks have no error messages explicitly defined.\"), mdx(\"h3\", {\n \"id\": \"example-3\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#example-3\",\n \"aria-label\": \"example 3 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n parentName: \"pre\",\n \"className\": \"language-sol\",\n \"metastring\": \"title=src/Adapters/Algebra/PluginV1.sol highlight={1} lineNumbers=true lineOffset=234\",\n \"title\": \"src/Adapters/Algebra/PluginV1.sol\",\n \"highlight\": \"{1}\",\n \"lineNumbers\": \"true\",\n \"lineOffset\": \"234\"\n }, \"require(!timepoints[startIndex].initialized); // if not initialized, then all subsequent ones too\\n\")), mdx(\"h3\", {\n \"id\": \"recommendation-3\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#recommendation-3\",\n \"aria-label\": \"recommendation 3 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise each to be set so to increase the legibility of the codebase and aid in validating the \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"require\"), \" checks' conditions.\"), mdx(\"h3\", {\n \"id\": \"alleviation-3\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#alleviation-3\",\n \"aria-label\": \"alleviation 3 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Alleviation:\"), mdx(\"p\", null, \"All referenced \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"require\"), \" checks have been converted to \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"if-revert\"), \" checks with explicit \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"error\"), \" declarations, addressing this exhibit.\"), mdx(ViewDiffButton, {\n repoUrl: \"https://github.com/SteerProtocol/core-v2\",\n mainHash: \"1eef5f69971e4d1ffa77012516646a38aa38517c\",\n fixHash: \"4f6535a8a25ddd41794119143a2d73d01f4c6d34\",\n gitHubIssue: \"0\",\n mdxType: \"ViewDiffButton\"\n }), mdx(\"h2\", {\n \"id\": \"span-idpv1-05cpv1-05c-misleading-function-namespan\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h2\",\n \"href\": \"#span-idpv1-05cpv1-05c-misleading-function-namespan\",\n \"aria-label\": \"span idpv1 05cpv1 05c misleading function namespan permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), mdx(\"span\", {\n id: \"PV1-05C\"\n }, \"PV1-05C: Misleading Function Name\")), mdx(\"table\", null, mdx(\"thead\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"thead\"\n }, mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Type\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Severity\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Location\"))), mdx(\"tbody\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"tbody\"\n }, mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"/reports/steer-protocol-algebra-v4-hook-integration-688c6d5b07dd3b0018c7b26d/appendix/finding-types#code-style\"\n }, \"Code Style\")), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"img\", {\n parentName: \"td\",\n \"className\": \"o-severity o-informational\",\n \"src\": \"https://omniscia.io/report-assets/informational.png\"\n })), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L280\"\n }, \"PluginV1.sol:L280\"))))), mdx(\"h3\", {\n \"id\": \"description-4\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#description-4\",\n \"aria-label\": \"description 4 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Description:\"), mdx(\"p\", null, \"The \", mdx(\"a\", {\n parentName: \"p\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L339-L356\"\n }, mdx(\"inlineCode\", {\n parentName: \"a\"\n }, \"PluginV1::_writeTimepointAndUpdateFee\")), \" function, contrary to what its name implies, will solely write a timepoint and will not update any fees.\"), mdx(\"h3\", {\n \"id\": \"example-4\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#example-4\",\n \"aria-label\": \"example 4 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n parentName: \"pre\",\n \"className\": \"language-sol\",\n \"metastring\": \"title=src/Adapters/Algebra/PluginV1.sol highlight={6} lineNumbers=true lineOffset=274\",\n \"title\": \"src/Adapters/Algebra/PluginV1.sol\",\n \"highlight\": \"{6}\",\n \"lineNumbers\": \"true\",\n \"lineOffset\": \"274\"\n }, \"function beforeSwap(address, address, bool, int256, uint160, bool, bytes calldata)\\n external\\n onlyPool\\n returns (bytes4, uint24, uint24)\\n{\\n _writeTimepointAndUpdateFee();\\n (bool success,) = address(this).call(abi.encodeWithSignature(\\\"_handleSwapLogic()\\\"));\\n if (!success) {\\n emit LogicExecutionFailed(\\\"Swap Logic Execution Failed\\\", abi.encodePacked(msg.data));\\n }\\n return (IAlgebraPlugin.beforeSwap.selector, 0, 0);\\n}\\n\")), mdx(\"h3\", {\n \"id\": \"recommendation-4\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#recommendation-4\",\n \"aria-label\": \"recommendation 4 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise the function to be aptly renamed, ensuring it properly represents its contents.\"), mdx(\"h3\", {\n \"id\": \"alleviation-4\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#alleviation-4\",\n \"aria-label\": \"alleviation 4 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Alleviation:\"), mdx(\"p\", null, \"The function was aptly renamed to indicate it simply writes a timepoint, addressing this exhibit.\"), mdx(ViewDiffButton, {\n repoUrl: \"https://github.com/SteerProtocol/core-v2\",\n mainHash: \"1eef5f69971e4d1ffa77012516646a38aa38517c\",\n fixHash: \"4f6535a8a25ddd41794119143a2d73d01f4c6d34\",\n gitHubIssue: \"0\",\n mdxType: \"ViewDiffButton\"\n }), mdx(\"h2\", {\n \"id\": \"span-idpv1-06cpv1-06c-redundant-distinction-of-conditionalsspan\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h2\",\n \"href\": \"#span-idpv1-06cpv1-06c-redundant-distinction-of-conditionalsspan\",\n \"aria-label\": \"span idpv1 06cpv1 06c redundant distinction of conditionalsspan permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), mdx(\"span\", {\n id: \"PV1-06C\"\n }, \"PV1-06C: Redundant Distinction of Conditionals\")), mdx(\"table\", null, mdx(\"thead\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"thead\"\n }, mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Type\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Severity\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Location\"))), mdx(\"tbody\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"tbody\"\n }, mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"/reports/steer-protocol-algebra-v4-hook-integration-688c6d5b07dd3b0018c7b26d/appendix/finding-types#gas-optimization\"\n }, \"Gas Optimization\")), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"img\", {\n parentName: \"td\",\n \"className\": \"o-severity o-informational\",\n \"src\": \"https://omniscia.io/report-assets/informational.png\"\n })), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L305\"\n }, \"PluginV1.sol:L305\"), \", \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L308\"\n }, \"L308\"))))), mdx(\"h3\", {\n \"id\": \"description-5\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#description-5\",\n \"aria-label\": \"description 5 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Description:\"), mdx(\"p\", null, \"The referenced conditionals will execute the same statements if they evaluate to \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"true\"), \".\"), mdx(\"h3\", {\n \"id\": \"example-5\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#example-5\",\n \"aria-label\": \"example 5 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n parentName: \"pre\",\n \"className\": \"language-sol\",\n \"metastring\": \"title=src/Adapters/Algebra/PluginV1.sol highlight={1,3,4,5} lineNumbers=true lineOffset=304\",\n \"title\": \"src/Adapters/Algebra/PluginV1.sol\",\n \"highlight\": \"{1,3,4,5}\",\n \"lineNumbers\": \"true\",\n \"lineOffset\": \"304\"\n }, \"if (!isTendNeeded) {\\n // When tend is not needed\\n rebalance(liquidities, _pos, isSwapNeeded);\\n} else if (!isSwapNeeded) {\\n rebalance(liquidities, _pos, isSwapNeeded);\\n}\\n\")), mdx(\"h3\", {\n \"id\": \"recommendation-5\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#recommendation-5\",\n \"aria-label\": \"recommendation 5 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise them to be combined into a single conditional, optimizing the code's gas cost.\"), mdx(\"h3\", {\n \"id\": \"alleviation-5\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#alleviation-5\",\n \"aria-label\": \"alleviation 5 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Alleviation:\"), mdx(\"p\", null, \"The Steer Protocol team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.\"), mdx(\"h2\", {\n \"id\": \"span-idpv1-07cpv1-07c-repeated-constant-declarationsspan\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h2\",\n \"href\": \"#span-idpv1-07cpv1-07c-repeated-constant-declarationsspan\",\n \"aria-label\": \"span idpv1 07cpv1 07c repeated constant declarationsspan permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), mdx(\"span\", {\n id: \"PV1-07C\"\n }, \"PV1-07C: Repeated Constant Declarations\")), mdx(\"table\", null, mdx(\"thead\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"thead\"\n }, mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Type\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Severity\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Location\"))), mdx(\"tbody\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"tbody\"\n }, mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"/reports/steer-protocol-algebra-v4-hook-integration-688c6d5b07dd3b0018c7b26d/appendix/finding-types#code-style\"\n }, \"Code Style\")), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"img\", {\n parentName: \"td\",\n \"className\": \"o-severity o-informational\",\n \"src\": \"https://omniscia.io/report-assets/informational.png\"\n })), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L60\"\n }, \"PluginV1.sol:L60\"), \", \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L64\"\n }, \"L64\"))))), mdx(\"h3\", {\n \"id\": \"description-6\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#description-6\",\n \"aria-label\": \"description 6 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Description:\"), mdx(\"p\", null, \"The referenced \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"constant\"), \" declarations point to the same underlying value.\"), mdx(\"h3\", {\n \"id\": \"example-6\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#example-6\",\n \"aria-label\": \"example 6 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n parentName: \"pre\",\n \"className\": \"language-sol\",\n \"metastring\": \"title=src/Adapters/Algebra/PluginV1.sol highlight={1,5} lineNumbers=true lineOffset=59\",\n \"title\": \"src/Adapters/Algebra/PluginV1.sol\",\n \"highlight\": \"{1,5}\",\n \"lineNumbers\": \"true\",\n \"lineOffset\": \"59\"\n }, \"uint256 internal constant DIVISOR = 100_00;\\n/// @dev maximum value that can be passed in total weight parameter of tend\\nuint256 internal constant TOTAL_WEIGHT_MAX = 100_00;\\n\\nuint256 internal constant DIVISOR100 = 100;\\n\")), mdx(\"h3\", {\n \"id\": \"recommendation-6\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#recommendation-6\",\n \"aria-label\": \"recommendation 6 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise a single \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"constant\"), \" to be utilized in their place.\"), mdx(\"h3\", {\n \"id\": \"alleviation-6\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#alleviation-6\",\n \"aria-label\": \"alleviation 6 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Alleviation:\"), mdx(\"p\", null, \"Both declarations have been omitted in favour of a single constant, addressing this exhibit.\"), mdx(ViewDiffButton, {\n repoUrl: \"https://github.com/SteerProtocol/core-v2\",\n mainHash: \"1eef5f69971e4d1ffa77012516646a38aa38517c\",\n fixHash: \"4f6535a8a25ddd41794119143a2d73d01f4c6d34\",\n gitHubIssue: \"0\",\n mdxType: \"ViewDiffButton\"\n }), mdx(\"h2\", {\n \"id\": \"span-idpv1-08cpv1-08c-unresolved-todo-commentspan\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h2\",\n \"href\": \"#span-idpv1-08cpv1-08c-unresolved-todo-commentspan\",\n \"aria-label\": \"span idpv1 08cpv1 08c unresolved todo commentspan permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), mdx(\"span\", {\n id: \"PV1-08C\"\n }, \"PV1-08C: Unresolved TODO Comment\")), mdx(\"table\", null, mdx(\"thead\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"thead\"\n }, mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Type\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Severity\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Location\"))), mdx(\"tbody\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"tbody\"\n }, mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"/reports/steer-protocol-algebra-v4-hook-integration-688c6d5b07dd3b0018c7b26d/appendix/finding-types#standard-conformity\"\n }, \"Standard Conformity\")), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"img\", {\n parentName: \"td\",\n \"className\": \"o-severity o-informational\",\n \"src\": \"https://omniscia.io/report-assets/informational.png\"\n })), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L121\"\n }, \"PluginV1.sol:L121\"))))), mdx(\"h3\", {\n \"id\": \"description-7\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#description-7\",\n \"aria-label\": \"description 7 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Description:\"), mdx(\"p\", null, \"The referenced \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"helper\"), \" contract is presently inaccessible due to pointing to an incorrect address.\"), mdx(\"h3\", {\n \"id\": \"example-7\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#example-7\",\n \"aria-label\": \"example 7 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n parentName: \"pre\",\n \"className\": \"language-sol\",\n \"metastring\": \"title=src/Adapters/Algebra/PluginV1.sol highlight={1} lineNumbers=true lineOffset=120\",\n \"title\": \"src/Adapters/Algebra/PluginV1.sol\",\n \"highlight\": \"{1}\",\n \"lineNumbers\": \"true\",\n \"lineOffset\": \"120\"\n }, \"address internal constant helper = 0x0000000000000000000000000000000000000050;\\n\")), mdx(\"h3\", {\n \"id\": \"recommendation-7\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#recommendation-7\",\n \"aria-label\": \"recommendation 7 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise the proper address to be utilized here after the conclusion of the audit report to ensure the \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"PluginV1\"), \" contract behaves as expected.\"), mdx(\"h3\", {\n \"id\": \"alleviation-7\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#alleviation-7\",\n \"aria-label\": \"alleviation 7 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Alleviation:\"), mdx(\"p\", null, \"The Steer Protocol team evaluated this exhibit but opted to acknowledge it in the current iteration of the codebase.\"), mdx(\"h2\", {\n \"id\": \"span-idpv1-09cpv1-09c-unused-contract-constantsspan\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h2\",\n \"href\": \"#span-idpv1-09cpv1-09c-unused-contract-constantsspan\",\n \"aria-label\": \"span idpv1 09cpv1 09c unused contract constantsspan permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), mdx(\"span\", {\n id: \"PV1-09C\"\n }, \"PV1-09C: Unused Contract Constants\")), mdx(\"table\", null, mdx(\"thead\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"thead\"\n }, mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Type\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Severity\"), mdx(\"th\", {\n parentName: \"tr\",\n \"align\": null\n }, \"Location\"))), mdx(\"tbody\", {\n parentName: \"table\"\n }, mdx(\"tr\", {\n parentName: \"tbody\"\n }, mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"/reports/steer-protocol-algebra-v4-hook-integration-688c6d5b07dd3b0018c7b26d/appendix/finding-types#code-style\"\n }, \"Code Style\")), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"img\", {\n parentName: \"td\",\n \"className\": \"o-severity o-informational\",\n \"src\": \"https://omniscia.io/report-assets/informational.png\"\n })), mdx(\"td\", {\n parentName: \"tr\",\n \"align\": null\n }, mdx(\"b\", null, \"PluginV1.sol\"), \":\", mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 1\"\n }, \"I-1:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L59\"\n }, \"L59\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 2\"\n }, \"I-2:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L60\"\n }, \"L60\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 3\"\n }, \"I-3:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L62\"\n }, \"L62\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 4\"\n }, \"I-4:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L64\"\n }, \"L64\"), mdx(\"br\", null), \"\\u2022 \", mdx(\"span\", {\n title: \"Instance 5\"\n }, \"I-5:\"), \" \", mdx(\"a\", {\n parentName: \"td\",\n \"href\": \"https://github.com/SteerProtocol/core-v2/blob/1eef5f69971e4d1ffa77012516646a38aa38517c/src/Adapters/Algebra/PluginV1.sol#L66\"\n }, \"L66\"))))), mdx(\"h3\", {\n \"id\": \"description-8\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#description-8\",\n \"aria-label\": \"description 8 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Description:\"), mdx(\"p\", null, \"The referenced \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"constant\"), \" declarations remain unused.\"), mdx(\"h3\", {\n \"id\": \"example-8\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#example-8\",\n \"aria-label\": \"example 8 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n parentName: \"pre\",\n \"className\": \"language-sol\",\n \"metastring\": \"title=src/Adapters/Algebra/PluginV1.sol highlight={11,12,14,16} lineNumbers=true lineOffset=48\",\n \"title\": \"src/Adapters/Algebra/PluginV1.sol\",\n \"highlight\": \"{11,12,14,16}\",\n \"lineNumbers\": \"true\",\n \"lineOffset\": \"48\"\n }, \"/// @notice Fee info\\n/// @dev Fee rates, each multiplied by 10,000\\n/// (a TOTAL_FEE of 100 means a 1% cut of total uniswap fees)\\n/// @dev Total fraction of fees not going towards LPs, multiplied by 10,000\\nuint256 public constant TOTAL_FEE = 15_00;\\n/// @dev Total fraction of fees going towards Steer (as opposed to going towards strategist)\\nuint256 public constant STEER_FRACTION_OF_FEE = 66_67;\\n/// @dev Total fraction of fees going towards strategies\\nuint256 public constant STRATEGIST_FRACTION_OF_FEE = 33_33;\\nuint256 internal constant FEE_DIVISOR = 100_00;\\nuint256 internal constant ONE_MINUS_FEE = FEE_DIVISOR - TOTAL_FEE;\\nuint256 internal constant DIVISOR = 100_00;\\n/// @dev maximum value that can be passed in total weight parameter of tend\\nuint256 internal constant TOTAL_WEIGHT_MAX = 100_00;\\n\\nuint256 internal constant DIVISOR100 = 100;\\n\\nuint256 internal constant FIVE = 5;\\n\\n/// @dev first deposit should mint MIN_SHARES or greater number of shares\\nuint256 internal constant MIN_SHARES = 1_000_000;\\n\")), mdx(\"h3\", {\n \"id\": \"recommendation-8\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#recommendation-8\",\n \"aria-label\": \"recommendation 8 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise them to be omitted, optimizing the code's syntax.\"), mdx(\"h3\", {\n \"id\": \"alleviation-8\",\n \"style\": {\n \"position\": \"relative\"\n }\n }, mdx(\"a\", {\n parentName: \"h3\",\n \"href\": \"#alleviation-8\",\n \"aria-label\": \"alleviation 8 permalink\",\n \"className\": \"anchor before\"\n }, mdx(\"svg\", {\n parentName: \"a\",\n \"aria-hidden\": \"true\",\n \"focusable\": \"false\",\n \"height\": \"16\",\n \"version\": \"1.1\",\n \"viewBox\": \"0 0 16 16\",\n \"width\": \"16\"\n }, mdx(\"path\", {\n parentName: \"svg\",\n \"fillRule\": \"evenodd\",\n \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n }))), \"Alleviation:\"), mdx(\"p\", null, \"All unused \", mdx(\"inlineCode\", {\n parentName: \"p\"\n }, \"constant\"), \" declarations have been omitted as advised.\"), mdx(ViewDiffButton, {\n repoUrl: \"https://github.com/SteerProtocol/core-v2\",\n mainHash: \"1eef5f69971e4d1ffa77012516646a38aa38517c\",\n fixHash: \"4f6535a8a25ddd41794119143a2d73d01f4c6d34\",\n gitHubIssue: \"0\",\n mdxType: \"ViewDiffButton\"\n }));\n}\n;\nMDXContent.isMDXComponent = true;","headings":[{"depth":2,"value":"PV1-01C: Duplicate Validation of Initialization"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation:"},{"depth":2,"value":"PV1-02C: Generic Typographic Mistake"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation:"},{"depth":2,"value":"PV1-03C: Inefficient Signature Encodings"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation:"},{"depth":2,"value":"PV1-04C: Inexistent Error Messages"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation:"},{"depth":2,"value":"PV1-05C: Misleading Function Name"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation:"},{"depth":2,"value":"PV1-06C: Redundant Distinction of Conditionals"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation:"},{"depth":2,"value":"PV1-07C: Repeated Constant Declarations"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation:"},{"depth":2,"value":"PV1-08C: Unresolved TODO Comment"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation:"},{"depth":2,"value":"PV1-09C: Unused Contract Constants"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation:"}]}},"pageContext":{"slug":"/code-style/PluginV1-PV1/","prev":{"label":"PluginHelper.sol (PHR-C)","link":"/code-style/PluginHelper-PHR"},"next":{"label":"Whitelist.sol (WTS-C)","link":"/code-style/Whitelist-WTS"}}},"staticQueryHashes":["1954253342","2328931024","2501019404","973074209"]}